Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for Window to Load Before Executing Javascript Callback #42

Merged
merged 7 commits into from
Mar 25, 2021
Merged

Wait for Window to Load Before Executing Javascript Callback #42

merged 7 commits into from
Mar 25, 2021

Conversation

sshropshire
Copy link
Contributor

Summary of changes

  • Add javascript to check for window load status/event before running javascript callbacks

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner March 4, 2021 20:23
@sarahkoop @sshropshire
Run javascript event notifications after window has loaded.
9f93a72 
Signed-off-by: Steven Shropshire <steven.shropshire@getbraintree.com>
@sarahkoop @sshropshire
Update CHANGELOG.
bebb705 
Signed-off-by: Steven Shropshire <steven.shropshire@getbraintree.com>
@sarahkoop @sshropshire
Modify CHANGELOG.
b9c09d7 
Signed-off-by: Steven Shropshire <steven.shropshire@getbraintree.com>
@sarahkoop @sshropshire
Fix javascript injection unit test.
4b7d39a 
Signed-off-by: Steven Shropshire <steven.shropshire@getbraintree.com>
@sarahkoop @sshropshire
Add TODOs.
192eb77 
Signed-off-by: Steven Shropshire <steven.shropshire@getbraintree.com>
@sarahkoop @sshropshire
Remove new line restriction from regex.
a3b626b 
Signed-off-by: Steven Shropshire <steven.shropshire@getbraintree.com>
@sarahkoop @sshropshire
Remove trailing new lines from javascript source.
3d71d3f 
Signed-off-by: Steven Shropshire <steven.shropshire@getbraintree.com>
@sshropshire sshropshire force-pushed the run_javascript_after_window_loaded branch from b4f463a to 3d71d3f Compare March 25, 2021 20:13
@sshropshire sshropshire merged commit 4bff178 into master Mar 25, 2021
@sshropshire sshropshire deleted the run_javascript_after_window_loaded branch March 25, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gesa gesa gesa approved these changes

@billwerges billwerges billwerges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sshropshire @gesa @billwerges @sarahkoop